Repository navigation
ci: CI modeled on yetone/magpie (macOS leg, plugin tests + coverage, package check, tag release) - #29
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Keep a cheap PR/push shipgate: one required job (ubuntu-latest · Node 24 · DSH 0.2.0-rc.2). Drop windows, Node 22, and DSH 0.2.1-alpha.1 from the required matrix; they can return later as nightly/manual. Lint, npm test, and build-client --check are unchanged. Verifier: not run (workflow-only change; CI will exercise on this PR).
Birfy
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d538b82c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - package-ecosystem: npm | ||
| # Plugins only declare peer dependencies (no lockfile), so ds-bot is the one npm project. | ||
| directory: /ds-bot |
There was a problem hiding this comment.
When this weekly job runs, Dependabot reads the npm project in the configured directory; ds-bot/package.json has no workspace entry for dev/harness, so /ds-bot does not discover dev/harness/package.json. Consequently its exact jsdom and oxlint dependencies, which supply test/lint tooling, never receive these updates. Add a separate npm update entry for the harness while retaining the DSH ignore there.
AGENTS.md reference: AGENTS.md:L30-L30
Useful? React with 👍 / 👎.
…wLab#31) - Test (PR gate, one job as in ThinkFlowLab#31, same required name): lint and bundle check first, ds-bot + social + tree suites (incl. tree-host and plugins/tree/test/tree.test.js) in one coverage run (job summary + lcov artifact); main's runs are never cancelled. - package: npm-pack ds-bot, social and tree and check main/exports/files are packed and no test/dev files; strict tsc on types/*.d.ts; CHANGELOG Unreleased check; actionlint. - tests-ok: one aggregate check. - Compatibility (nightly, manual, and on PRs touching it): Windows, macOS, Node 22 and DSH 0.2.1-alpha.1 through the same composite action, job names prefixed 'compat ·'. - Release on v* tags: version check, wait for a green Test run, tarballs + CHANGELOG notes. - CodeQL (javascript-typescript, actions) and Dependabot; actions pinned to SHAs with persist-credentials off and read-only permissions. No secrets.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0507e1040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| concurrency: | ||
| group: test-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} |
There was a problem hiding this comment.
When three main pushes overlap (A running, tagged B pending, then C arriving), GitHub Actions replaces B because a concurrency group retains only one pending run; cancel-in-progress: false protects only A, the running member. Since every main SHA still shares test-refs/heads/main, B can lose its only Test run, and the Wait for a green Test run on this commit step in .github/workflows/release.yml then treats that cancelled conclusion as failure and rejects the release. Give main runs a SHA-specific group or omit concurrency grouping for main.
Useful? React with 👍 / 👎.
| run: node .github/scripts/check-pack.mjs | ||
| - name: Typecheck the plugin API (types/*.d.ts, strict) | ||
| working-directory: ds-bot | ||
| run: npx --yes -p typescript@5.9.3 tsc --noEmit --strict --skipLibCheck types/*.d.ts |
There was a problem hiding this comment.
When types/flybot.d.ts acquires an unknown type or conflicting declaration, this package job still succeeds: tsc --help --all defines --skipLibCheck as “Skip type checking all .d.ts files,” and types/*.d.ts supplies only such files. This makes the new strict API gate a no-op for semantic declaration errors, allowing broken published types through; remove this flag or compile a .ts consumer fixture instead.
Useful? React with 👍 / 👎.
# Conflicts: # .github/workflows/test.yml
3 participants
Implements #30: CI modeled on yetone/magpie's
test.ymlandrelease.yml, adapted to FlyBot.Builds on #31 (slim PR gate) and #35 (Compatibility nightly), both now on main. Latest main is merged into this branch with a merge commit, so no history was rewritten.
Checklist (from #30)
cancel-in-progressonly off main); lint and the client-bundle check run before tests; 5-minute timeouts onnpm ciand the DSH installubuntu-latest · Node 24 · DSH 0.2.0-rc.2(as in ci: slim Test matrix to ubuntu Node 24 + DSH 0.2.0-rc.2 #31). The other legs stay in ci: Compatibility nightly + local Mac CI (follows #31) #35'snightly.yml(Compatibility), which this PR leaves untouched. I dropped my owncompat.ymlin favour of it. The gate's steps live in a composite action,.github/actions/flybot-tests, which nightly.yml could adopt later to get the plugin suites too. The gate keeps ci: Compatibility nightly + local Mac CI (follows #31) #35'spushpaths-ignorefor docs.plugins/tree/test/tree.test.js);test/tree-host.test.jskeeps running in ds-bot's suitecoverage-lcovartifactpackagejob:.github/scripts/check-pack.mjspacks ds-bot, social and tree and checks every main/exports/files entry is packed and no test/dev files are; stricttscontypes/*.d.ts; CHANGELOG Unreleased check; actionlinttests-okaggregate (test + package)release.ymlonv*tags: tag must matchds-bot/package.json, waits for a green Test run on the commit, then publishes the tarballs with the version's CHANGELOG section (.github/scripts/release-notes.mjs). UsesGITHUB_TOKENonly. It cannot run from a PR, so it is untested until the first tag.persist-credentials: falseui-preview.yml; would usedev/ui-shots.mjs)checkJsneeds@types/nodeand fixes first)docker.yml)Changes from the earlier apache/magpie-based draft
.github/labeler.yml, the PR template.persist-credentials: false,tests-ok, CodeQL, Dependabot (it keeps the SHA pins current), actionlint (now a step inpackage).Branch protection
Main still requires all four legs. Since #31, three of those checks are never reported on PRs again, so PRs stay blocked until protection changes. Set the required checks to:
ubuntu-latest · Node 24 · DSH 0.2.0-rc.2(keep)packageandtests-ok(new, recommended).tests-okalone would also do, since it needs both.ubuntu-latest · Node 24 · DSH 0.2.1-alpha.1,ubuntu-latest · Node 22 · DSH 0.2.0-rc.2andwindows-latest · Node 24 · DSH 0.2.0-rc.2. They now run ascompat · …in Compatibility (nightly.yml), which is not required.Analyze (javascript-typescript)andAnalyze (actions).Closes #30